add precedence to splat operators; test for associativity

grammar.js

@@ -16,8 +16,6 @@ module.exports = grammar({
   name: 'hcl',
 
   conflicts: $ => [
-    [$.attr_splat],
-    [$.full_splat],
     // string literals are just quoted template without template stuff
     [$.string_lit, $.quoted_template],
   ],
@@ -145,18 +143,15 @@ module.exports = grammar({
 
     splat: $ => choice($.attr_splat, $.full_splat),
 
-    attr_splat: $ => seq(
+    attr_splat: $ => prec.right(seq(
-      '.',
+      '.*',
-      '*',
       repeat($.get_attr),
-    ),
+    )),
 
-    full_splat: $ => seq(
+    full_splat: $ => prec.right(seq(
-      '[',
+      '[*]',
-      '*',
-      ']',
       repeat(choice($.get_attr, $.index)),
-    ),
+    )),
 
     for_expr: $ => choice($.for_tuple_expr, $.for_object_expr),
 

src/grammar.json

@@ -480,15 +480,14 @@
       ]
     },
     "attr_splat": {
+      "type": "PREC_RIGHT",
+      "value": 0,
+      "content": {
         "type": "SEQ",
         "members": [
           {
             "type": "STRING",
-          "value": "."
+            "value": ".*"
-        },
-        {
-          "type": "STRING",
-          "value": "*"
           },
           {
             "type": "REPEAT",
@@ -498,21 +497,17 @@
             }
           }
         ]
+      }
     },
     "full_splat": {
+      "type": "PREC_RIGHT",
+      "value": 0,
+      "content": {
         "type": "SEQ",
         "members": [
           {
             "type": "STRING",
-          "value": "["
+            "value": "[*]"
-        },
-        {
-          "type": "STRING",
-          "value": "*"
-        },
-        {
-          "type": "STRING",
-          "value": "]"
           },
           {
             "type": "REPEAT",
@@ -531,6 +526,7 @@
             }
           }
         ]
+      }
     },
     "for_expr": {
       "type": "CHOICE",
@@ -1210,12 +1206,6 @@
     }
   ],
   "conflicts": [
-    [
-      "attr_splat"
-    ],
-    [
-      "full_splat"
-    ],
     [
       "string_lit",
       "quoted_template"

src/node-types.json

@@ -756,6 +756,10 @@
     "type": ".",
     "named": false
   },
+  {
+    "type": ".*",
+    "named": false
+  },
   {
     "type": "/",
     "named": false
@@ -800,6 +804,10 @@
     "type": "[",
     "named": false
   },
+  {
+    "type": "[*]",
+    "named": false
+  },
   {
     "type": "]",
     "named": false

test/corpus/splat.txt

@@ -52,9 +52,9 @@ foo = bar.*.foo
         (variable_expr
           (identifier))
         (splat
-          (attr_splat))
+          (attr_splat
             (get_attr
-          (identifier))))))
+              (identifier))))))))
 
 ================================================================================
 full splat
@@ -72,6 +72,36 @@ foo = bar[*].foo
         (variable_expr
           (identifier))
         (splat
-          (full_splat))
+          (full_splat
             (get_attr
-          (identifier))))))
+              (identifier))))))))
+
+================================================================================
+full splat repeated
+================================================================================
+
+foo = bar[*][*].a.b.c[d]
+
+--------------------------------------------------------------------------------
+
+(config_file
+  (body
+    (attribute
+      (identifier)
+      (expression
+        (variable_expr
+          (identifier))
+        (splat
+          (full_splat))
+        (splat
+          (full_splat
+            (get_attr
+              (identifier))
+            (get_attr
+              (identifier))
+            (get_attr
+              (identifier))
+            (index
+              (expression
+                (variable_expr
+                  (identifier))))))))))